This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
dkorpel
force-pushed
the
thread-closure-fix
branch
from
7ee92c8 to
f1527a2
Compare
thewilsonator
approved these changes
Aug 19, 2021
Contributor
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
otherwise looks good
src/core/thread/osthread.d
Outdated
| t.__ctor({x = 3;}); | ||
| return t; | ||
| } | ||
| assert(!__traits(compiles, () @nogc => fun(thread, 3) )); |
RazvanN7
approved these changes
Aug 20, 2021
dkorpel
force-pushed
the
thread-closure-fix
branch
from
f1527a2 to
b4006f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reboot of #3520 which I can't re-open.The bug is gone now Issue 20150 - -dip1000 defeated by pure is fixed, so this PR simply adds a test case.