Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Use workaround until issue 22372 is fixed#3585

Merged
dlang-bot merged 1 commit intodlang:masterfrom
teodutu:loop-optimisation-workaround
Oct 11, 2021
Merged

Use workaround until issue 22372 is fixed#3585
dlang-bot merged 1 commit intodlang:masterfrom
teodutu:loop-optimisation-workaround

Conversation

@teodutu
Copy link
Copy Markdown
Member

@teodutu teodutu commented Oct 11, 2021

This temporary change is needed in order to unblock this other PR: dlang/dmd#13116
These changed will be rolled back when this issue is fixed: https://issues.dlang.org/show_bug.cgi?id=22372

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22372 blocker Loop index incorrectly optimised out for -release -O

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3585"

@dlang-bot dlang-bot merged commit 578fce9 into dlang:master Oct 11, 2021
@teodutu teodutu deleted the loop-optimisation-workaround branch October 13, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants