This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Use return value of _d_arrayctor#3611
Merged
RazvanN7 merged 5 commits intodlang:masterfrom Nov 9, 2021
Merged
Conversation
This aims to solve the warnings issued by the compiler when lowering to strongly pure calls such as `_d_arrayctor(a, b)` and ignoring the return value. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
The current form still does not perform NRVO Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Contributor
|
Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3611" |
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
ibuclaw
reviewed
Nov 8, 2021
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
changed the title
RazvanN7
approved these changes
Nov 9, 2021
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Nov 10, 2021
This PR synchronises the compiler with the new signature of _d_arrayctor implemented in dlang/druntime#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Nov 10, 2021
This PR synchronises the compiler with the new signature of _d_arrayctor implemented in dlang/druntime#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Nov 10, 2021
This PR synchronises the compiler with the new signature of _d_arrayctor implemented in dlang/druntime#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Nov 19, 2021
This PR synchronises the compiler with the new signature of _d_arrayctor implemented in dlang/druntime#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Nov 19, 2021
This PR synchronises the compiler with the new signature of
_d_arrayctor implemented in dlang/druntime#3611
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/dmd
that referenced
this pull request
Dec 2, 2021
This PR synchronises the compiler with the new signature of
_d_arrayctor implemented in dlang/druntime#3611
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/druntime
that referenced
this pull request
Dec 2, 2021
This undoes the changes brought by dlang#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
added a commit
to teodutu/druntime
that referenced
this pull request
Dec 2, 2021
This undoes the changes brought by dlang#3611 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is needed by PR dlang/dmd#13116 so that the return value of
_d_arrayctoris used and not ignored. Because_d_arrayctorwas and still is a strongly pure function, ignoring its return value causes warnings and risks being removed by the compiler.