This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Merged
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3671" |
WalterBright
force-pushed
the
int128-2
branch
2 times, most recently
from
8872697 to
562ac6b
Compare
ibuclaw
reviewed
Jan 15, 2022
| { | ||
| return inc(com(c)); // ~c + 1 | ||
| if (c.lo == 0) | ||
| c.hi = -c.hi; |
Member
There was a problem hiding this comment.
To properly validate neg, please add the following test:
const Cm10_0 = Cent(0, -10);
const Cm10_1 = Cent(-1, ~10);
const Cm10_3 = Cent(-3, ~10);
assert(neg(C10_0) == Cm10_0);
assert(neg(C10_1) == Cm10_1);
assert(neg(C10_3) == Cm10_3);
562ac6b to
6f9c617
Compare
WalterBright
force-pushed
the
int128-2
branch
from
6f9c617 to
6e4d232
Compare
ibuclaw
approved these changes
Jan 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ibuclaw 's suggestions from #3663