Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Fix Issue 22717 - TypeInfo_Struct.equals swaps lhs and rhs parameters#3718

Merged
RazvanN7 merged 1 commit intomasterfrom
fix22717
Feb 1, 2022
Merged

Fix Issue 22717 - TypeInfo_Struct.equals swaps lhs and rhs parameters#3718
RazvanN7 merged 1 commit intomasterfrom
fix22717

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Jan 31, 2022

This depends on dlang/dmd#13593.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 31, 2022

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22717 critical object.TypeInfo_Struct.equals swaps lhs and rhs parameters

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3718"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jan 31, 2022
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this have a two-stage PR? First using static if (__VERSION__ >= 2099), then second removing the static if after the compiler change is in.

@kinke
Copy link
Contributor Author

kinke commented Jan 31, 2022

Looks like we'll need the static if (__VERSION__ >= 2099) anyway for as long as git describe returns v2.098* for DMD master, so changed accordingly.

@kinke kinke marked this pull request as ready for review January 31, 2022 23:50
@RazvanN7 RazvanN7 merged commit 55f563d into master Feb 1, 2022
@ibuclaw ibuclaw deleted the fix22717 branch February 1, 2022 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants