Add back pragma(inline, false) to fix vibe.d#3873
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3873" |
|
Doesn't seem to fix the issue. |
197ecea to
fb036e5
Compare
|
I've put |
| // needed for CTFE: https://github.com/dlang/druntime/pull/3870#issuecomment-1178800718 | ||
| pragma(inline, false); |
There was a problem hiding this comment.
is this a DMD specific issue? LDC does not recognise pragma(inline, whatever); unless it is outside the function.
There was a problem hiding this comment.
I think the problem is DMD's front-end inliner. This is a specially recognized function for CTFE, and inlining the body into another function makes DMD not recognize it anymore.
|
Phobos seems to have a network failure on Freebsd. Please re-push this. |
fb036e5 to
178d6b2
Compare
#3870 (comment)