Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Add back pragma(inline, false) to fix vibe.d#3873

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:arrayappend-inline
Jul 8, 2022
Merged

Add back pragma(inline, false) to fix vibe.d#3873
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:arrayappend-inline

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 8, 2022

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3873"

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jul 8, 2022

Doesn't seem to fix the issue.

@dkorpel dkorpel force-pushed the arrayappend-inline branch from 197ecea to fb036e5 Compare July 8, 2022 10:53
@dkorpel
Copy link
Contributor Author

dkorpel commented Jul 8, 2022

I've put pragma(inline, false) inside the function again

Comment on lines +39 to +40
// needed for CTFE: https://github.com/dlang/druntime/pull/3870#issuecomment-1178800718
pragma(inline, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a DMD specific issue? LDC does not recognise pragma(inline, whatever); unless it is outside the function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is DMD's front-end inliner. This is a specially recognized function for CTFE, and inlining the body into another function makes DMD not recognize it anymore.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jul 8, 2022

Phobos seems to have a network failure on Freebsd. Please re-push this.

@dkorpel dkorpel force-pushed the arrayappend-inline branch from fb036e5 to 178d6b2 Compare July 8, 2022 11:56
@dlang-bot dlang-bot merged commit d1d65f9 into dlang:master Jul 8, 2022
@dkorpel dkorpel deleted the arrayappend-inline branch July 8, 2022 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants