This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Workaround 11461: avoid strong purity inference by passing null pointer to onOutOfMemoryError#753
Merged
MartinNowak merged 1 commit intodlang:masterfrom Mar 24, 2014
Merged
Conversation
Contributor
|
Same mistake as in dlang/dmd#3342 : the (unofficial) term is "strong", not "strict". |
rainers
changed the title
Member
Author
Hmmm, I must have picked up that term from the other PR. I changed the title. |
Contributor
|
As mentioned though, the compiler could statically catch that the passed parameter is null, and decide to apply strong purity to the weakly pure function? |
Member
It's a workaround not a solution so it must not be perfect. |
Member
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Mar 24, 2014
Workaround 11461: avoid strong purity inference by passing null pointer to onOutOfMemoryError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://d.puremagic.com/issues/show_bug.cgi?id=11461, this seems the better workaround as it allows keeping the pure attribute.
I added the same to onInvalidMemorypertionError, it suffered from the same issue.