This repository was archived by the owner on Oct 12, 2022. It is now read-only.
[new AA] core.internal.hash fixes#932
Merged
MartinNowak merged 1 commit intodlang:masterfrom Sep 5, 2014
Merged
Conversation
src/core/internal/hash.d
Outdated
Member
There was a problem hiding this comment.
I take it that being a template hashOf relies on deduction? Is it necessary to keep commented out attributes?
Contributor
Author
There was a problem hiding this comment.
Hmm... Yes. This comments isn't necessary. I'll remove them.
28debdd to
0d35812
Compare
src/core/internal/hash.d
Outdated
Member
There was a problem hiding this comment.
Ehm? Shouldn't we just remove or fix it?
Contributor
Author
There was a problem hiding this comment.
Ok, I'll remove this comment.
0d35812 to
f763c8b
Compare
Member
|
Looks fine, I'd rather wait on one of druntime guys to take a look though ;) P.S. Any unittests for this stuff? |
f763c8b to
463c9d5
Compare
Contributor
Author
|
I've add test for typeof(null); |
Contributor
Author
|
@MartinNowak ping |
MartinNowak
added a commit
that referenced
this pull request
Sep 5, 2014
[new AA] core.internal.hash fixes
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the follownig changes:
@trusted nothrow: we can't guarantee that struct hashOf is@trustedornothrow.typeof(null)case for hashOf added.seedHashhas unmarked withprivate, because this function is usefull for hash chaining inside usertoHashhashOffor AA: avoid to call postblit.