fix nothrow issues

[MartinNowak]

• revealed by enabling nothrow checks in functions
  with inline asm

[WalterBright]

Add a blank line before the nothrow: line. (github is insisting I'm not logged in, sigh, but it lets me post this!)

[9rnsr]

Same fix would be necessary in rt/arraybyte.d, rt/arraydouble.d, rt/arrayfloat.d, rt/arrayreal.d, rt/arrayshort.d.

[MartinNowak]

Weird, I only got an error for arrayint. Will recheck.

[MartinNowak]

Oh, you just found a copy&paste bug in arrayint.d, it's the only one that performs a runtime check for sse2 support on X86_64.
#976

[9rnsr]

In windows platforms, enumProcessThreads function in core/sys/windows/threadaux.d is not nothrow. Inside dll_fixTLS function in core/sys/windows/dll.d, its call silently violates the nothrow attribute.

To fix the issue, we should assume the enumProcessThreads function call as nothrow, like follows:

    bool dll_fixTLS( HINSTANCE hInstance, void* tlsstart, void* tlsend, void* tls_callbacks_a, int* tlsindex ) nothrow
    {
[snip]
        scope(failure) assert(0);    // Add this line to tell to the compiler that the exception code path will never be reached.

        if( !enumProcessThreads(
            function (uint id, void* context) nothrow {
                dll_aux.LdrpTlsListEntry* entry = cast(dll_aux.LdrpTlsListEntry*) context;
                return dll_aux.addTlsData( getTEB( id ), entry.tlsstart, entry.tlsend, entry.tlsindex );
            }, entry ) )
            return false;

[snip]
    }

[MartinNowak]

To fix the issue, we should assume the enumProcessThreads function call as nothrow, like follows:

Just tried to fix it properly and got stuck in core.thread with the dreaded _d_monitorenter isn't nothrow issue, so I went with your scope(failure) assert(0);.

[braddr]

Martin, file a bug to track fixing it more correctly and note the bug number in the source.

[MartinNowak]

Martin, file a bug to track fixing it more correctly and note the bug number in the source.

Issue 13561

[9rnsr]

Please add the bugzilla number 13561 in the comment.

[9rnsr]

Others looks good to me. After the comment fix, I'll toggle on auto-merging.

[MartinNowak]

done

[9rnsr]

Auto-merge toggled on