Avoid creation of a temporary probe file for newer compilers#1316
Open
wilzbach wants to merge 1 commit intodlang:masterfrom
Open
Avoid creation of a temporary probe file for newer compilers#1316wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach wants to merge 1 commit intodlang:masterfrom
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
wilzbach
commented
Dec 26, 2017
|
|
||
| auto fil = generatePlatformProbeFile(); | ||
| bool canUseStdin = this.canUseStdin(compiler_binary); | ||
| string fil = canUseStdin ? generatePlatformProbeFile().toNativeString() : "-"; |
Contributor
Author
There was a problem hiding this comment.
Of course we could also remove the temp file after the exit of the current scope.
Member
|
Temp files get deleted at the end of the run, would be better to make that mechanism more reliable instead of increasing the complexity for that single task. dub/source/dub/internal/utils.d Lines 40 to 47 in 79475c0 I'd guess the main source for the remaining temp files is dub's missing CTRL+C sigint handling, in particular in combination with dub run where you want to exit the child process, but terminate the parent instead.
|
Contributor
Author
|
FYI: the new JSON API (e.g. See also: https://dlang.org/changelog/2.079.0.html#json_includes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I chated with @RazvanN7 today, he complained about DUB creating a lot of temporary probing files in his current working directory.
A quick look at the code revealed that DUB uses this probing hack to extract information
from DMD. Since dlang/dmd#6880 (2.076.0), it's possible
to avoid the need of creating a temporary file for this hack.
Of course, it would be better to read this file from the compiler directly...