Check whether DUB is provided by the release#214
Conversation
|
Will merge and release later today. |
script/install.sh
Outdated
| local arch="zip" | ||
| fi | ||
|
|
||
| if [[ $ver > "2.072.0z" ]]; then |
There was a problem hiding this comment.
Hmm on a second though: this seems to exclude 2.072.0, should I change it to sth. like 2.071.9?
script/install.sh
Outdated
| if [ $os != linux ] && [ $os != osx ]; then | ||
| fatal "no ldc binaries available for $os" | ||
| fi | ||
| if [[ $ver > "1.1.0z" ]]; then |
There was a problem hiding this comment.
similar here: should I change it to 1.0.99?
There was a problem hiding this comment.
That's what the z is for 1.0z should work.
|
Had to enable squash merges for this repo first. |
| fi | ||
| if [ "$has_dub_included" -eq 0 ] ; then | ||
| install_dub | ||
| fi |
There was a problem hiding this comment.
Mmh, this still queries code.dlang.org when a compiler is already installed.
|
You also didn't adopt the activate scripts to work w/o a separate dub installation. |
Hmm, it still "works", because it's sets the |
|
Also seems to fail, at least during initial installation, due to |
|
I'll revert this for now to not impact any usage. |
Check whether DUB is provided by the release merged-on-behalf-of: Martin Nowak <code@dawg.eu>
Check whether DUB is provided by the release merged-on-behalf-of: Martin Nowak <code@dawg.eu>
3 participants
DUB is provided by DMD (>= 2.072.0) and LDC (>= 1.1.0), so there's no need to download it again.