appveyor: build windows installer by rainers · Pull Request #284 · dlang/installer

rainers · 2017-12-29T18:46:30Z

no docs for now.

dlang-bot · 2017-12-29T18:46:30Z

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

rainers · 2017-12-29T18:51:25Z

@wilzbach Could you reenable appveyor for this repo? Thanks.

wilzbach · 2017-12-29T18:55:04Z

Could you reenable appveyor for this repo? Thanks.

Done :)

wilzbach · 2017-12-29T18:59:04Z

appveyor.yml

+build_script:
+  - cd c:/projects/
+  - ps: |
+    Start-FileDownload "http://downloads.dlang.org/releases/2.x/$Env:D_VERSION}/dmd.$Env:D_VERSION.windows.7z" -FileName dmd2.7z


BTW instead of copy/pasting this all over, we are working towards a windows variant of the installer script. It got a bit stalled though as I'm no expert on Windows nor user.

BTW instead of copy/pasting this all over, we are working towards a windows variant of the installer script. It got a bit stalled though as I'm no expert on Windows nor user.

I also noticed after creating this PR. Downloading the compiler is usually a smaller problem, but tedious.

rainers · 2017-12-29T19:34:48Z

Done :)

Thanks.

wilzbach

Looks great for an initial version!
Do you plan to do more in this PR or should we squash and merge?

wilzbach · 2017-12-30T08:56:09Z

appveyor.yml

+        7z x bup.zip dm\bin\implib.exe > $null
+        Start-FileDownload "http://semitwist.com/download/app/dmd-localextras.7z" -FileName extras.7z
+        7z x extras.7z > $null
+        Start-FileDownload "http://nsis.sourceforge.net/mediawiki/images/c/c9/Inetc.zip" -FileName inetc.zip


One experience I have from maintaining D's CIs is that the network isn't 100% reliable, especially the FreeBSD Server from digitalmars.
If we can't put those things on downloads.dlang.org, it be be worthwhile to push them into a GitHub repository as mirror. This would have the additional advantage of being a mirror in our control.

wilzbach · 2017-12-30T08:59:18Z

appveyor.yml

+  - git clone --depth 1 --branch %BRANCH% https://github.com/dlang/phobos.git "%BASE%/phobos"
+  - git clone --depth 1 --branch %BRANCH% https://github.com/dlang/tools.git "%BASE%/tools"
+  - git clone --depth 1 --branch %BRANCH% https://github.com/dlang/dlang.org.git "%BASE%/dlang.org"
+  - git clone --depth 1 --branch %BRANCH% https://github.com/dlang/dub.git "%BASE%/dub"


Could have been a loop and/or function calls to repeat in case of network failures, e.g. https://github.com/dlang/dmd/blob/master/.circleci/run.sh

Of course, this isn't needed for this initial version.

I've kept that task for your installer helper script #275 ;-)

We don't need to clone the repos for the install script

rainers · 2017-12-30T09:17:48Z

Do you plan to do more in this PR or should we squash and merge?

Not really, but I'm not sure this should go live for now:

the localextras are pretty dated, they should be updated or replaced by a new package on downloads.dlang.org
@MartinNowak could be right that this isn't really that helpful for generating releases, e.g it won't trigger nightlies for dmd updates.
Martin might not be able to use these builds to do an actual release because it doesn't easily integrate with his workflow.

wilzbach · 2017-12-30T09:26:52Z

I think it's still a good step forward to merge this, because it will provide CI feedback for people improving the installer in the future.
Currently we don't have that "many" tests.

MartinNowak · 2017-12-30T18:28:07Z

appveyor.yml

+        7z x dm857c.zip > $null
+        Start-FileDownload "http://ftp.digitalmars.com/bup.zip" -FileName bup.zip
+        7z x bup.zip dm\bin\implib.exe > $null
+        Start-FileDownload "http://semitwist.com/download/app/dmd-localextras.7z" -FileName extras.7z


That's hasn't been used in ages, you can take the binaries from the old release.

That's hasn't been used in ages, you can take the binaries from the old release.

How do you get anything new into that, e.g. link.exe or snn.lib?

MartinNowak · 2017-12-30T18:32:35Z

If we're going in the direction of testing the build script, we should figure out how to make the VBox build in build_all optional.
Since the build script is rarely update and almost exclusively breaks due to the other repos, I'm not sure how useful testing it would be.

If on the other hand we just want to test the installer, we should download an already released dmd.windows.7z and build the installer from that. This could even be the nightly https://nightlies.dlang.org/dmd-nightly/dmd.master.windows.7z in case new files need to be shipped.

wilzbach · 2018-01-03T00:41:20Z

Since the build script is rarely update and almost exclusively breaks due to the other repos, I'm not sure how useful testing it would be.

I think it's very useful, because this gives reviewers and contributors a informative feedback when doing changes.

Since the build script is rarely update and almost exclusively breaks due to the other repos, I'm not sure how useful testing it would be.

Fair point, but a bit unrelated, but maybe @braddr can add a new section "test install" to DAutoTest?

wilzbach · 2018-01-17T01:47:10Z

As the load of dlang/dmd is increasing I setup a different AppVeyor account for dlang/installer.
Imho the downsides of the annoying AppVeyor login in case manual rebuilds are needed outweighs the advantage of

not being blocking by dlang/dmd (and putting less stress on the AppVeyor builds of dlang/dmd).
having more than enough resources to do a daily cron

rainers · 2020-01-31T18:13:55Z

Now on Azure.

appveyor: build windows installer

76c2cae

wilzbach closed this Dec 29, 2017

wilzbach reopened this Dec 29, 2017

wilzbach reviewed Dec 29, 2017

View reviewed changes

fix ps indent

c4e6fae

rainers added 4 commits December 29, 2017 20:37

/dev/null -> $null

a8f426f

fix download url

5cee507

fix dmc zip filename

4dca0fe

set VCDIR/SDKDIR

f14ee1c

rainers force-pushed the appveyor branch from 7fc95cd to f14ee1c Compare December 29, 2017 19:50

call vsvarsall.bat

cdc2b85

rainers force-pushed the appveyor branch from 0603475 to cdc2b85 Compare December 29, 2017 19:56

explicit path to NSIS

e210e80

rainers force-pushed the appveyor branch from e118f98 to e210e80 Compare December 29, 2017 20:07

install nsis plugin inetc

1b83533

wilzbach approved these changes Dec 30, 2017

View reviewed changes

MartinNowak reviewed Dec 30, 2017

View reviewed changes

dlang-bot added needs rebase and removed needs rebase labels Jan 1, 2018

wilzbach closed this Jan 17, 2018

wilzbach reopened this Jan 17, 2018

wilzbach mentioned this pull request May 16, 2018

Build {32,64}-bit Windows binaries on Travis dlang/dub#1471

Closed

rainers closed this Jan 31, 2020

Uh oh!

Conversation

rainers commented Dec 29, 2017

Uh oh!

dlang-bot commented Dec 29, 2017

Bugzilla references

Uh oh!

rainers commented Dec 29, 2017

Uh oh!

wilzbach commented Dec 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rainers commented Dec 29, 2017

Uh oh!

wilzbach left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rainers commented Dec 30, 2017

Uh oh!

wilzbach commented Dec 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinNowak commented Dec 30, 2017

Uh oh!

wilzbach commented Jan 3, 2018

Uh oh!

wilzbach commented Jan 17, 2018

Uh oh!

rainers commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants