[experimental] build lld on appveyor by rainers · Pull Request #286 · dlang/installer

rainers · 2017-12-30T09:45:11Z

No description provided.

dlang-bot · 2017-12-30T09:45:11Z

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

rainers · 2017-12-30T11:44:31Z

closing for now, trying it on a different account

rainers · 2017-12-30T12:49:45Z

Seems to work now.

MartinNowak

Looks mostly good.

MartinNowak · 2017-12-30T20:07:09Z

windows/build_lld.bat

+
+call "c:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars32.bat"
+git clone --depth 1 --branch %LLVM_BRANCH% https://github.com/llvm-mirror/llvm.git llvm || exit /B 1
+git clone --depth 1 --branch %LLVM_BRANCH% https://github.com/llvm-mirror/lld.git llvm\tools\lld || exit /B 1


I'd rather go with the released sources, then we also have proper versioning.
http://releases.llvm.org/download.html#5.0.1

http://releases.llvm.org/5.0.1/lld-5.0.1.src.tar.xz
http://releases.llvm.org/5.0.1/llvm-5.0.1.src.tar.xz

Bonus, check gpg signatures locally and put the sha256sums in the script (prolly simpler than gpg on window).

d5b36c0005824f07ab093616bdff247f3da817cae2c51371e1d1473af717d895 lld-5.0.1.src.tar.xz 5fa7489fc0225b11821cab0362f5813a05f2bcf2533e8a4ea9c9c860168807b0 llvm-5.0.1.src.tar.xz

Changed to download the tarballs. How would you verify the SHA? (I don't think this is super important, though.)

MartinNowak · 2017-12-30T20:12:57Z

windows/build_lld.bat

+devenv LLVM.sln /project lld /Build "MinSizeRel|Win32" || exit /B 1
+
+if not exist ..\bin\nul md ..\bin
+copy MinSizeRel\bin\lld-link.exe ..\bin


Compress the exe and output with a version number, e.g. lld-link-5.0.1.zip.

Building a zip file now. I'm not sure compressed exes are so great, I suspect it makes program execution slower than when reading the program from a fast disk or the file cache.

MartinNowak · 2017-12-30T20:14:08Z

appveyor.yml

+  - bin\lld-link.exe -> windows\build_lld.bat
+
+artifacts:
+  - path: bin\lld-link.exe


Not sure whether you could use variables here bin\lld-link-%VERSION%.zip.

According to the docs lld-link-$(VERSION).zip should work.

MartinNowak · 2017-12-30T20:14:57Z

windows/build_lld.bat

+set CMAKE_OPT=%CMAKE_OPT% -DLLVM_INCLUDE_DIRS="c:/projects/llvm/include"
+
+cmake %CMAKE_OPT% ..\llvm || exit /B 1
+devenv LLVM.sln /project lld /Build "MinSizeRel|Win32" || exit /B 1


Can we trigger this manually, or build the script when the version/file changed? Running half an hour for every unrelated change seems wasteful.

AppVeyor supports crons, so we could run it once a day?

The build can be triggered manually if you login to Appveyor. LLD is cached (from master builds) and is only rebuilt if the dependency changes, i.e. currently the batch file.

For a fully manual build, you could add.

branches: { only: [manually-triggered-build] }

But indeed using the cache is also a good idea.

MartinNowak · 2017-12-30T22:15:34Z

windows/build_lld.bat

+cmake %CMAKE_OPT% ..\llvm || exit /B 1
+devenv LLVM.sln /project lld /Build "MinSizeRel|Win32" || exit /B 1
+
+zip ../../lld-link-%LLVM_VER%.zip MinSizeRel\bin\lld-link.exe


cd MinSizeRel\bin 7z a ..\..\..\..\lld-link-%LLMV_VER%.zip lld-link.exe

MartinNowak · 2017-12-30T22:17:25Z

appveyor.yml

+  - 'lld-link-%LLVM_VER%.zip -> windows\build_lld.bat'
+
+artifacts:
+  - path: bin\lld-link-$(LLVM_VER).zip


without the bin\ now

And I guess it's also using %LLVM_VER% expansion.

- root seems to be project checkout

MartinNowak · 2017-12-31T13:40:31Z

AppVeyor would still copy the artifacts for every commit on master.
Let's simply make a couple of inactive build-X branches for the different builds, then we can manually trigger them and we have a clean history of artifacts.

rainers · 2017-12-31T15:46:58Z

AppVeyor would still copy the artifacts for every commit on master.

Artifacts could also be uploaded when rebuilt, see https://github.com/dlang/installer/pull/284/files#diff-180360612c6b8c4ed830919bbb4dd459R58 for an example.
But it might be a bit troublesome to find the last build in this case, so another branch sounds good to me, too.

- https://www.appveyor.com/docs/build-environment/#version-control-systems

MartinNowak · 2017-12-31T19:11:39Z

Signed and uploaded
http://downloads.dlang.org/other/
http://ftp.digitalmars.com/

rainers · 2018-01-01T16:04:39Z

Signed and uploaded

Thanks. Should we add a similar build branch for the mingw libraries? The build tool dlang/tools#267 could be moved to the installer in that case.

MartinNowak · 2018-01-02T20:39:15Z

Yes, let's add all the irregularly build ones.

rainers · 2018-01-02T21:34:32Z

Yes, let's add all the irregularly build ones.

#289

build lld on appveyor

b709e22

fix cache syntax, added artifacts

341f5ad

rainers closed this Dec 30, 2017

rainers added 5 commits December 30, 2017 12:46

combine commands to single batch

2b1f725

move build into batch file

858f63e

fix artifact path

c263365

fix condition

152235a

move branch setting to batch to make cache depend on it

3620d74

rainers reopened this Dec 30, 2017

rainers mentioned this pull request Dec 30, 2017

Windows installer: install mingw libs and improve VS selection #281

Merged

MartinNowak reviewed Dec 30, 2017

View reviewed changes

rainers force-pushed the build_lld branch from 212cd4b to cf6c5e7 Compare December 30, 2017 21:36

build from release tar, create zip file

17b950d

rainers force-pushed the build_lld branch from cf6c5e7 to 17b950d Compare December 30, 2017 21:38

MartinNowak reviewed Dec 30, 2017

View reviewed changes

use 7z instead of zip

2631412

rainers force-pushed the build_lld branch from d54b6ef to 2631412 Compare December 30, 2017 22:47

MartinNowak changed the base branch from master to build-lld December 31, 2017 13:38

fix paths for artifacts

34563da

- root seems to be project checkout

MartinNowak force-pushed the build_lld branch 2 times, most recently from d6153bd to 72503fb Compare December 31, 2017 15:36

no need to cache artifacts for build-lld branch

9f41f12

MartinNowak force-pushed the build_lld branch from 72503fb to 5b114fa Compare December 31, 2017 15:44

MartinNowak force-pushed the build_lld branch from 5b114fa to 121868d Compare December 31, 2017 15:47

MartinNowak added 2 commits December 31, 2017 17:02

verify sha256 checksums

af230f5

core.autocrlf input already default

7e25cbc

- https://www.appveyor.com/docs/build-environment/#version-control-systems

MartinNowak force-pushed the build_lld branch from 121868d to 7e25cbc Compare December 31, 2017 16:03

MartinNowak merged commit f026a95 into dlang:build-lld Dec 31, 2017

Uh oh!

Comments

Conversation

rainers commented Dec 30, 2017

Uh oh!

dlang-bot commented Dec 30, 2017

Bugzilla references

Uh oh!

rainers commented Dec 30, 2017

Uh oh!

rainers commented Dec 30, 2017

Uh oh!

MartinNowak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinNowak Dec 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinNowak commented Dec 31, 2017

Uh oh!

rainers commented Dec 31, 2017

Uh oh!

MartinNowak commented Dec 31, 2017

Uh oh!

rainers commented Jan 1, 2018

Uh oh!

MartinNowak commented Jan 2, 2018

Uh oh!

rainers commented Jan 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MartinNowak Dec 30, 2017 •

edited

Loading