Skip to content

Comments

fix uninitialised suffix on macOS#334

Merged
wilzbach merged 1 commit intodlang:masterfrom
John-Colvin:patch-1
Jul 31, 2018
Merged

fix uninitialised suffix on macOS#334
wilzbach merged 1 commit intodlang:masterfrom
John-Colvin:patch-1

Conversation

@John-Colvin
Copy link
Contributor

The problem was introduced in #239 and presumable copied in #218

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @John-Colvin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm shouldn't the Travis CI on OSX warn us about this?

@John-Colvin
Copy link
Contributor Author

You would think so, yes.

@wilzbach wilzbach merged commit a801edc into dlang:master Jul 31, 2018
@John-Colvin John-Colvin deleted the patch-1 branch July 31, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants