less gnu-y alternative to find -printf#335
Conversation
|
Thanks for your pull request and interest in making D better, @John-Colvin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
I would have expected this to be caught already by travis as well. |
Same here. Though considering that this script is used by Travis for their builtin D support, I'm partially glad it did work. https://travis-ci.org/dlang/installer/jobs/399790376 Any idea why it's working fine on Travis OSX? |
|
(FYI: Deployed this and the other PR) |
|
Maybe they have the GNU tools by default? They are in homebrew as From |
|
It's not mentioned here: https://docs.travis-ci.com/user/reference/osx, but yeah apparently newer brew versions even have a special flag for this (https://apple.stackexchange.com/questions/69223/how-to-replace-mac-os-x-utilities-with-gnu-core-utilities). Maybe that's what they do on Travis.
Any idea how we could reverse this? |
|
I made mistake above, We can do |
|
cool, let's see what happens :O |
because not everywhere has gnu tools (e.g. macOS)