std.stdio: improve standardization of C I/O functions across runtimes#1093
std.stdio: improve standardization of C I/O functions across runtimes#1093kinke wants to merge 2 commits intodlang:masterfrom
Conversation
|
Fails on Windows. |
There was a problem hiding this comment.
This cast from dchar to wchar is necessary as I fixed the fputwc* function declarations to take wchar_t (wchar on Windows, else dchar) characters instead of int. Not sure about the DMC runtime, so I left it alone (taking an int character).
|
Please squash all those "fix" commits together to keep the history clean. |
std/stdio.d
Outdated
There was a problem hiding this comment.
Unfortunately, this isn't universally true for LDC – on 32 bit Windows, our best bet right now is MinGW (working exception support).
There was a problem hiding this comment.
Okay thx, I've removed the LDC specifics.
|
What ever happened to this? It seems its trivial enough that it should have been pulled. |
|
Concur with @AndrejMitrovic what's the holdback? In any case there are 2 paths: rebase or death ;) |
ghost
mentioned this pull request
|
Rebased here: #1942 |
ghost
closed this
5 participants
Standardize the primary C I/O functions into a common (GCC) interface:
On OSX/FreeBSD, use provided fgetc_unlocked/fputc_unlocked functions instead of using the locked versions internally (may increase performance for narrow streams).