Skip to content

Comments

fix Issue 10644 - Win64: wrong code when passing arguments through ...#1423

Merged
rainers merged 1 commit intodlang:masterfrom
WalterBright:fix10644
Jul 20, 2013
Merged

fix Issue 10644 - Win64: wrong code when passing arguments through ...#1423
rainers merged 1 commit intodlang:masterfrom
WalterBright:fix10644

Conversation

@WalterBright
Copy link
Member

fix http://d.puremagic.com/issues/show_bug.cgi?id=10644

The test cases are the unittests.

@rainers
Copy link
Member

rainers commented Jul 19, 2013

The test cases are the unittests.

Unfortunately unittest are not run yet for win64.

Actually _argptr is the documented way to get the va_list. Shouldn't it work for all platforms? I tried it for win32 at it seems ok there.

@WalterBright
Copy link
Member Author

Unfortunately unittest are not run yet for win64.

True, but isn't part of the point of these fixes to get the unittests to run?

Actually _argptr is the documented way to get the va_list. Shouldn't it work for all platforms? I tried it for win32 at it seems ok there.

Yes, it should work for the others. I just fixed the Win64 code, though.

@rainers
Copy link
Member

rainers commented Jul 20, 2013

True, but isn't part of the point of these fixes to get the unittests to run?

Sure, I'll update #1411 to not skip this test.

@rainers
Copy link
Member

rainers commented Jul 20, 2013

Yes, it should work for the others. I just fixed the Win64 code, though.

Ok, let's make the unification different pull requenst.

rainers added a commit that referenced this pull request Jul 20, 2013
fix Issue 10644 - Win64: wrong code when passing arguments through ...
@rainers rainers merged commit 1bd22b2 into dlang:master Jul 20, 2013
@WalterBright WalterBright deleted the fix10644 branch July 20, 2013 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants