Skip to content

Comments

Fix Issue 10227: Add missing file I/O functions for Win64 DMD and Windows LDC#1538

Merged
1 commit merged intodlang:masterfrom
dymk:win64-fileio
Oct 24, 2013
Merged

Fix Issue 10227: Add missing file I/O functions for Win64 DMD and Windows LDC#1538
1 commit merged intodlang:masterfrom
dymk:win64-fileio

Conversation

@dymk
Copy link
Contributor

@dymk dymk commented Aug 31, 2013

Closes 10227

@dnadlinger
Copy link
Contributor

@rainers, @redstar, …: Good to merge?

@rainers
Copy link
Member

rainers commented Sep 16, 2013

I have almost the same patches in #1411, though I have used "alias fileno _fileno;". Declaring the function seems fine, too. So no objections from my side.

@dymk
Copy link
Contributor Author

dymk commented Sep 16, 2013

I'd rather #1411 be merged instead if it includes better unittests (and it seems more fixes in general), because I didn't know how to enable win64 unittests in this PR.

But hey, if this looks good, that's still fine by me.

@ghost
Copy link

ghost commented Oct 24, 2013

I'll merge this since #1411 is still broken, and these changes shouldn't be blocked by it. I'll CC rainers to rebase his pull.

ghost pushed a commit that referenced this pull request Oct 24, 2013
Fix Issue 10227: Add missing file I/O functions for Win64 DMD and Windows LDC
@ghost ghost merged commit ce23685 into dlang:master Oct 24, 2013
@ghost ghost mentioned this pull request Oct 24, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants