fix reg in appender#1683
Merged
dnadlinger merged 1 commit intodlang:masterfrom Nov 9, 2013
monarchdodra:AppenderFixup
Merged
Conversation
Member
|
Should it go to 2.064.3 ? |
Contributor
|
I don't think the original pull was included in 2.064, was it? One of the downsides of cherry-picking commits is that you can't easily list all branches/tags that contain a given change anymore (as it might have different commit IDs). |
Collaborator
Author
|
1529 is not in the official 2.064.2, that's for sure. I don't know the state of 2.064.3. If 1529 is in 2.064.3, then this needs to be merged in. I also opened 1684 to cleanup the code of 1529, but it's not a bug fix or anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the horrible reg I introduced in #1529
https://github.com/D-Programming-Language/phobos/pull/1529/files#r7536782