Skip to content

Comments

Fix issue 11580 - A unittest of std.stdio.rawRead cannot run and some unittests in std.stdio must run on Win64.#1712

Closed
k3kaimu wants to merge 1 commit intodlang:masterfrom
k3kaimu:issue11580
Closed

Fix issue 11580 - A unittest of std.stdio.rawRead cannot run and some unittests in std.stdio must run on Win64.#1712
k3kaimu wants to merge 1 commit intodlang:masterfrom
k3kaimu:issue11580

Conversation

@k3kaimu
Copy link

@k3kaimu k3kaimu commented Nov 22, 2013

@monarchdodra
Copy link
Collaborator

@braddr : Add @k3kaimu to the whitelist?

@CyberShadow
Copy link
Member

Do these unit tests actually pass? Even with no changes, I'm getting failing unit tests in Phobos on Win64.

Possibly related: #1411

@rainers
Copy link
Member

rainers commented Feb 14, 2014

Most of the unittests are never run on the Win64 build server, see the makefile changes in #1411. The change is correct, there is an identical patch in #1411.

@CyberShadow
Copy link
Member

What's blocking #1411, then? Should this be merged until #1411 can be merged, or closed as #1411 includes this patch?

@mihails-strasuns
Copy link

#1411 was merged, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants