Skip to content

Remove bug from staticIota in typecons#1755

Merged
monarchdodra merged 1 commit intomasterfrom
unknown repository
Dec 9, 2013
Merged

Remove bug from staticIota in typecons#1755
monarchdodra merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 6, 2013

step is not used -> if passed anything other than 1 as step, staticIota
will behave incorrectly.

step is not used -> if passed anything other than 1 as step, staticIota
will behave incorrectly.
@monarchdodra
Copy link
Collaborator

I had noticed this before, but since it is package, never bother with it. It will also fail with non-integers (eg, floats).

In any case, since it is only for internal use, I'm perfectly fine with fixing this by removing a feature, rather than adding un-needed complexity.

For reference, I had written and submitted a complete staticIota in #1440. It was dropped in favor of #1472.

@monarchdodra
Copy link
Collaborator

@braddr pinging for auto-tester authorization.

monarchdodra added a commit that referenced this pull request Dec 9, 2013
Remove bug from staticIota in typecons
@monarchdodra monarchdodra merged commit 913434e into dlang:master Dec 9, 2013
@ghost ghost deleted the fix branch December 14, 2013 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant