Remove deprecated crc32 and std.md5#1800
Conversation
|
Ping @jmdavis |
|
What was the deprecation deadline? |
|
It wasn't set. Looking at both files history, you can see they had been forgotten for the last 15 months, after std.digest was added, except for 2 sed which converted C-Style array to D-Style. So I just removed them directly, as I don't think any code using a recent phobos use them (importing them produces a warning). |
|
Fine, thanks. |
Remove deprecated crc32 and std.md5
|
Hum... I was going to suggest we move them in a "deprecated" folder for at least 1 release. There was no actual removal date, and this is an entire module we are talking about, so I suspect a user or two to be surprised by outright removal. Moving to IMO. @jmdavis ? |
|
Tester broke on win32. Why was this merged before the tester could finished chewing on it? As a result, master is now broken too. Please fix. |
|
@Geod24 I had forgotten it prior to that pull, because it wasn't in std, but I didn't add it to that pull, because it involved removing files. @monarchdodra It's been deprecated had a replacement for well over a year now (probably from before |
This removes two modules that had been deprecated by 6ff6adc (Sep 16, 2012).
I was about to remove only crc32, which should be hard to do, but as md5 was deprecated on the same commit, I included it as well. Any breakage introduced by this would be very easy to fix.