Remove deprecated std.metastrings#2134
Merged
jmdavis merged 1 commit intodlang:masterfrom Apr 29, 2014
Merged
Conversation
Contributor
Author
|
There are btw several other places where it says "Scheduled for deprecation in $date". Does that mean it can be removed at the mentioned date, or that it should be marked as |
Member
|
I recommend you look at #1766 (comment) to see how deprecation is generally handled in Phobos. |
Contributor
Author
|
@Geod24 Thanks, I've removed the comments instead, as described in the post. |
Member
|
This looks fine, but in addition to this, std.metastrings needs to be removed from the dlang.org repo, otherwise there will still be links to it. In particular, it's mentioned in std.ddoc and std_consolidated_header.dd. |
jmdavis
added a commit
that referenced
this pull request
Apr 29, 2014
Remove deprecated std.metastrings
Contributor
Author
|
Thanks, @jmdavis. See here: dlang/dlang.org#570 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment in the file says
It will be removed in March 2014.