std.math.findRoot 1. can now accept delegate with different value and argument types 2. allow tolerance have default value

[9il]

#1894 #1893 reopen

[9il]

../dmd/src/dmd -I../druntime/import -w -m64 -O -release -unittest -c -ofgenerated/osx/release/64/unittest/std/numeric.o -deps=generated/osx/release/64/unittest/std/numeric.deps.tmp std/numeric.d
Internal error: backend/cg87.c 925

[9il]

ICE 925 https://issues.dlang.org/show_bug.cgi?id=12057

[quickfur]

The ICE appears to have been fixed. I tried to merge into master, and it compiles and runs unittests fine. Could you please rebase to push the autotester to retest this PR? Thanks!

[9il]

@quickfur Thanks! I suppose PR rebased now. If it is not, please write me what I should do.

[mihails-strasuns]

Seems to still trigger the ICE

[9il]

ICE 64 bit only

[quickfur]

Gah, apparently the ICE is triggered only with -O; it worked fine when I tried to compile it with -main -unittest (without -O). Sounds like an optimizer bug.

[quickfur]

Found the ICE: it's caused by this line. I'm going to run dustmite on it to find the minimal code that causes this.

[quickfur]

Walter fixed the ICE. Hopefully the autotester will pass now...

[quickfur]

Looks like the previous failures are passing now. Should we merge? @Dicebot

[mihails-strasuns]

Please update the PR / commit to briefly explain intention of the change. "findRoot fix" says nothing to the reader - for me at least.

[9il]

@Dicebot, I have changed PR header. Is it what you suggest?

[mihails-strasuns]

Pretty much. Extra points if you can squash commits and amend the resulting commit message to something similar :) If you don't know how to do it:

# squashing
git fetch upstream
git rebase -i upstream/master
# text editor will open
# mark all commits but the first one as "s" (squash) instead of default "p" (pick)
# save and exit

# amending
git commit --amend
# text editor will open
# change commit message : first line is commit message title, rest go to commit message body

git push -f origin patch-2

It is not necessary but appreciated.

Anyway: I don't know a thing about numeric stuff so need another LGTM from other reviewer before merging.

[9il]

@Dicebot thank you! Next PR i will make properly. I created this one with github web-editor.

[quickfur]

ping
This code is ready to merge, we just need it to be rebased. Please update. :-)

[quickfur]

Auto-merge toggled on