Skip to content

Coding style fixup for PR 2500.#2552

Merged
ibuclaw merged 2 commits intodlang:masterfrom
quickfur:sumOfLogs_fixup
Sep 27, 2014
Merged

Coding style fixup for PR 2500.#2552
ibuclaw merged 2 commits intodlang:masterfrom
quickfur:sumOfLogs_fixup

Conversation

@quickfur
Copy link
Member

Fixup for PR #2500

As requested by Andrei.

As requested by Andrei.
@quickfur
Copy link
Member Author

ping @andralex

quickfur referenced this pull request Sep 23, 2014
@monarchdodra
Copy link
Collaborator

I'd be more comfortable with this change if there was any prior consistent at all to this module, or if this pull processed the entire module to give it said style.

3 lines of change seems random and nothing more than noise to a module without any consistent style to me.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 24, 2014

I agree with @monarchdodra - I have previously noted that std.numeric needs some love in #2524

A full file skirmish would be better.

@quickfur
Copy link
Member Author

Alrighty then. Full skirmish it is! Be ready in a couple o' hours, hopefully.

@quickfur
Copy link
Member Author

The deed is done. Destroy! :-)

@monarchdodra
Copy link
Collaborator

LGTM. I might have nitpicks, but not worth mentioning given the scope of this.

@quickfur
Copy link
Member Author

If you have nitpicks, please fire away. It's still not too late to fix them. :-)

@ibuclaw
Copy link
Member

ibuclaw commented Sep 27, 2014

Didn't look into too much detail of the changes, I'll trust the autotester to find anything you've mucked up in translation. But look good to me after a quick scroll down.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 27, 2014

Auto-merge toggled on

ibuclaw added a commit that referenced this pull request Sep 27, 2014
Coding style fixup for PR 2500.
@ibuclaw ibuclaw merged commit 4c0e38c into dlang:master Sep 27, 2014
@quickfur quickfur deleted the sumOfLogs_fixup branch September 27, 2014 20:21
@quickfur
Copy link
Member Author

Thanks!

@andralex
Copy link
Member

A belated note of thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants