Skip to content

Comments

attributes for inline asm#2572

Merged
DmitryOlshansky merged 1 commit intodlang:masterfrom
MartinNowak:asmAttributes
Oct 8, 2014
Merged

attributes for inline asm#2572
DmitryOlshansky merged 1 commit intodlang:masterfrom
MartinNowak:asmAttributes

Conversation

@MartinNowak
Copy link
Member

No description provided.

@monarchdodra
Copy link
Collaborator

WTF at failures. Does this have a pre-requisite on DMD? Did you test this on your end?

@yebblies
Copy link
Contributor

Does this have a pre-requisite on DMD?

Just a little.

@monarchdodra
Copy link
Collaborator

Just a little.

Link? It would be nice to have access to the background conversation.

@monarchdodra
Copy link
Collaborator

Link? It would be nice to have access to the background conversation.

dlang/dmd#4033

@yebblies
Copy link
Contributor

Link? It would be nice to have access to the background conversation.

Sometimes I forget not everybody is watching the dmd repo.

@MartinNowak
Copy link
Member Author

Yikes, looks like the autotester is hanging on the compile failures.
I will close this pull until we merged the compiler and runtime part.

@MartinNowak MartinNowak reopened this Oct 8, 2014
@MartinNowak
Copy link
Member Author

Should pass now.

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

DmitryOlshansky added a commit that referenced this pull request Oct 8, 2014
@DmitryOlshansky DmitryOlshansky merged commit ddae9ae into dlang:master Oct 8, 2014
@MartinNowak MartinNowak deleted the asmAttributes branch October 9, 2014 09:08
@joakim-noah
Copy link
Contributor

I'm getting a bunch of deprecation warnings like this when compiling phobos after updating to git HEAD just now:

std/internal/math/biguintx86.d(120): Deprecation: asm statement is assumed to be impure - mark it with 'pure' if it is not
std/internal/math/biguintx86.d-mixin-141(141): Deprecation: asm statement is assumed to be impure - mark it with 'pure' if it is not
std/internal/math/biguintx86.d(147): Deprecation: asm statement is assumed to be impure - mark it with 'pure' if it is not

@MartinNowak, one more pull for phobos may be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants