Add optional KeepTerminator param to splitLines.#278
Conversation
std/string.d
Outdated
There was a problem hiding this comment.
There is trailing whitespace is this function that needs to be cleaned up.
There was a problem hiding this comment.
Also, it's not a big deal, but the function's signature would be easier to read if the = had spaces around it.
There was a problem hiding this comment.
"There is trailing whitespace is this function that needs to be cleaned up."
I turned on Visible Whitespace in my editor, but I don't see any.
?
There was a problem hiding this comment.
That's weird, because I'm seeing 11 spaces on lines 1408 and 1413, both of which should be completely empty. I don't know why you're not seeing them in your editor.
There was a problem hiding this comment.
Oh, I see, you mean on the blank lines. I've never paid much attention to whitespace on blank lines before.
There was a problem hiding this comment.
Well, I set up my editor to highlight all tabs and trailing whitespace, so they become very obvious, very fast.
Add optional KeepTerminator param to splitLines.
|
Merged. |
Improve contributors script merged-on-behalf-of: Vladimir Panteleev <github@thecybershadow.net>
As suggested here: #277