std.math: №1, change protection

[9il]

Attribute was changed for RealFormat, floatTraits, floorImpl. This
suff is usefull (#3045) in other modules like std.numeric and
std.mathspecial.

[kuettler]

Hmm. This is exposing implementation details, aka enlarging the module's public interface for increased coupling. I guess the newly exposed code needs to be reviewed here. This is not a one line change. ;)

[9il]

You are welcome;) If you like numeric algorithms see also #2991. And if you have Windows please help with #2548

[JohanEngelen]

@9il Perhaps you can limit the changes to only add RealFormat and floatTraits to the public interface? (i.e. keep floorImpl and MANTISSA_LSB private)
Hope that expedites the merge.

[9il]

@JohanEngelen floorImpl is useful for optimization.
Programmer can use it when he handle special cases directly.

float floor(float x) @trusted pure nothrow @nogc
{
    // Special cases.
    if (isNaN(x) || isInfinity(x) || x == 0.0)
        return x;

    return floorImpl(x);
}

[quickfur]

ping

Is there anything else to do before merging this?

[9il]

looks like nothing

[ibuclaw]

Can we only expose RealFormat and FloatTraits for now, leaving the MANTISSA_LSB/MSB and floorImpl private unless we really need them later down the line.

[9il]

I think conceptually all this stuff may be package because we have mathspecial.

[9il]

For example we need floorImpl for future Bessel functions at std.mathspecial.

[DmitryOlshansky]

package is not public so I don't see any problem with this pull.

[DmitryOlshansky]

Auto-merge toggled on

[9il]

Thanks!