Skip to content

findRoot: fix Issue 14231#3028

Merged
MartinNowak merged 1 commit intodlang:masterfrom
9il:fr
Mar 14, 2015
Merged

findRoot: fix Issue 14231#3028
MartinNowak merged 1 commit intodlang:masterfrom
9il:fr

Conversation

@9il
Copy link
Member

@9il 9il commented Feb 28, 2015

@e10s
Copy link
Contributor

e10s commented Mar 2, 2015

Looks nice.

BTW, considering the difference between -0.0 and +0.0, the ddoc seems to say this function still requires f(a) <= -0 && +0 <= f(b) || f(b) <= -0 && +0 <= f(a), which has been implicitly contracted. Now that it allows (f(a) == 0 || f(b) == 0) && ( f(a) <= -0 && f(b) <= -0 || +0 <= f(a) && +0 <= f(b) ) as well, you could modify the description.

fix findRoot documatntation
@9il
Copy link
Member Author

9il commented Mar 5, 2015

Thanks! Docs was fixed.

@9il 9il changed the title fix Issue 14231 findRoot: fix Issue 14231 Mar 5, 2015
@MartinNowak
Copy link
Member

Auto-merge toggled on

@MartinNowak
Copy link
Member

thx

MartinNowak added a commit that referenced this pull request Mar 14, 2015
findRoot: fix Issue 14231
@MartinNowak MartinNowak merged commit 27d3a41 into dlang:master Mar 14, 2015
@9il 9il deleted the fr branch March 14, 2015 09:36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dollar sign. That should be $(D fax).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #3084

@9il 9il mentioned this pull request Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants