std.internal.math.gammafunction: loosen some tests for 64-bit reals.#3283
std.internal.math.gammafunction: loosen some tests for 64-bit reals.#3283WalterBright merged 1 commit intodlang:masterfrom
Conversation
|
Why? I like to have them tight, because they let me know when the algorithm changes in a way that makes the result less accurate. |
|
Simple - these tests assume 80-bit reals, and it's time to support other targets too, don't you think? We're talking about 3 relaxed assertions and 9 coverage tests now only enabled for x87 reals... |
|
Use |
|
Summary:
Using version blocks results in way clumsier code, we have enough of those PPC, PPC64, ARM, ARM64, MIPS, MIPS64 etc. stuff already in there (in LDC), so I'll stick with the |
std/internal/math/gammafunction.d
Outdated
There was a problem hiding this comment.
Again, please do not reduce the precision of 80 bit tests. Add a separate test for 64 bit reals.
|
Done. |
|
thanks! |
|
Auto-merge toggled on |
std.internal.math.gammafunction: loosen some tests for 64-bit reals.
As supplement for JohanEngelen@2ac2581 (1st commit of #3045; that commit alone doesn't depend on the other PR).