Skip to content

Fix-up coefficients and smallest denormal value for ieeeDouble in exp()#3388

Closed
ibuclaw wants to merge 1 commit intodlang:masterfrom
ibuclaw:exp53
Closed

Fix-up coefficients and smallest denormal value for ieeeDouble in exp()#3388
ibuclaw wants to merge 1 commit intodlang:masterfrom
ibuclaw:exp53

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 7, 2015

Addresses complaints in #3285

Apart from the failing unittest....

@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 7, 2015

By the way, how do you guys get the represented hexadecimal float? I've used "%.15a" format in the past, but it never prints a 0x1.... number for real types. I do get plenty of 0x9... and 0xb... hexadecimal floats though. ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, C2 was changed from the (128bit number) 1.428606820309417232121458176568075500134E-6L;, if we are going to have a branch for each float format, might as well have the number in the correct precision.

@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 25, 2015

Ping. @MartinNowak - this is for 2.068 release

@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 25, 2015

Also need to sort out https://issues.dlang.org/show_bug.cgi?id=14732

@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 29, 2015

Ping?

@DmitryOlshansky DmitryOlshansky added this to the 2.068 milestone Jul 9, 2015
@DmitryOlshansky
Copy link
Member

I'd opportunistically merge but have literally no iidea if this pull does the right thing. You might want to target the stable branch for 2.068 though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the same coefficients as above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the coefficients should be identical regardless of what platform / float format we are using.

@MartinNowak
Copy link
Member

Rebased and repopend against stable, see #3514.

@ibuclaw ibuclaw deleted the exp53 branch November 17, 2015 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants