Doc formatting fixes for DMD PR 4745#3722
Conversation
etc/c/curl.d
Outdated
There was a problem hiding this comment.
Does this actually work? I thought macros had to be self-contained within a comment block
There was a problem hiding this comment.
There was a problem hiding this comment.
Oops, right. Fixing.
BTW, are those even supposed to be doc comments? Doesn't seem like it, but I don't really know this module very well.
There was a problem hiding this comment.
Huh, you're right. These definitely do not refer to maxredirs.
There was a problem hiding this comment.
That surprised me because it does work for /// doc comments. Adjacent /// get merged before processing. At least it seems to work fine based on the results of dlang/druntime#1408 over at http://dtest.thecybershadow.net/artifact/website-fa397df5041e797d4ecdefd0231aa6ae97f9ea34-52af7a31c124ce2ec1c988269811b9fb/web/library-prerelease/core/cpuid/prefer_athlon.html
|
LGTM |
std/container/array.d
Outdated
There was a problem hiding this comment.
Really? It's necessary to have no whitespace here? Wouldn't that break a lot of existing ddocs?
There was a problem hiding this comment.
Actually, that one's unrelated to dlang/dmd#4745, but I tossed it in because I noticed the "ditto" is showing up in the generated docs ( http://dtest.thecybershadow.net/artifact/website-1d618eaba1a0a418cbe85589a97781591809b3fa-5a06ed4863a1b8ed5de4d7e83de8bae8/web/library-prerelease/std/container/array/array.remove_back.html , near the bottom of the page, in the last "Complexity" section).
But now that I look at the test results for this PR ( http://dtest.thecybershadow.net/results/efe54d2753dcaecdd25f95ec40132bc0d15ff2c1/a53d6f3607852ae15236d10fae4dbacdc86a24fb/ ), removing the space doesn't appear to have made any difference, so I'll revert this change.
|
Something odd with the std.socket changes. |
std/socket.d
Outdated
There was a problem hiding this comment.
What happened here? These lines seem to have been spuriously reordered.
There was a problem hiding this comment.
Argh. My text editor has an (overly) convenient key combo for "swap lines". Must've hit it my mistake without noticing. Will fix.
|
We should still change those etc.c.curl DDoc comments to be regular comments. |
|
Seems reasonable. Pressing the button. |
|
Auto-merge toggled on |
|
@Abscissa Please add a comment after updating a PR, as reviewers aren't otherwise notified of new commits. |
|
Looks good. Would have been nice to squash the commits though. |
Doc formatting fixes for DMD PR 4745
4 participants
Doc formatting fixes needed for dlang/dmd#4745