Workaround for dmd's checkwhitespace.d linking bug#3812
Closed
9il wants to merge 1 commit intodlang:masterfrom
9il:patch-3
Closed
Workaround for dmd's checkwhitespace.d linking bug#38129il wants to merge 1 commit intodlang:masterfrom 9il:patch-3
9il wants to merge 1 commit intodlang:masterfrom
9il:patch-3
Conversation
Contributor
|
This is not right. |
Member
Author
|
Yeah, we need to fix build script. But I don't understand it |
Member
|
WAT? I mean what's the problem with checkwhitespace? |
Member
Author
Looks like phobos source code was used from git branch but precompiled libphobos. IMHO |
Contributor
Nobody does. |
Member
|
I don't think this should be merged. We should fix the problem in dmd / makefiles / whatever. |
Member
Author
No hope |
Contributor
|
Worst case, just disable checkwhitespace in the phobos makefiles, get the other pull merged, then re-enable it. But modifying phobos to avoid an incorrect makefile setup is not really the way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link error: #2991 (comment)
I hope this PR will unblock #2991 .