Adjust expected result of test to match ARM and others#3819
Merged
dnadlinger merged 1 commit intodlang:masterfrom Nov 19, 2015
Merged
Adjust expected result of test to match ARM and others#3819dnadlinger merged 1 commit intodlang:masterfrom
dnadlinger merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Without rechecking the LDC results with the new expected value, but given how feqrel() works for subnormals, Win64 should yield 51 and the LLVM intrinsic (at least on Win64) 53. I.e., the tests still pass. I'm 99.999% sure about that. ;) |
Member
Author
|
Thanks @kinke - updated. |
Contributor
|
Auto-merge toggled on |
dnadlinger
added a commit
that referenced
this pull request
Nov 19, 2015
Adjust expected result of test to match ARM and others
Member
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the conversation and comparing of results in #3483 - the following was found for the result of
exp(-0x1.64p+9L):With feqrel giving the following number of mantissa bits in common (53 means identical to
0x0.06f84920bb2d3p-1022L).[*] UPDATE: Whoops, I forgot to set rounding mode as per unittest. These are now correct, except for the GCC intrinsic, which const-folded the result. :-)
Changing the test to the mode result returned yields (53 means identical to
0x0.06f84920bb2d4p-1022LSo Win64 is the odd one out (but we are not sure why) and the rest produce the exact same result.