Skip to content

Fix issue 15645 - Tuple.slice() causes memory corruption #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhdas wants to merge 3 commits into from
Closed

Fix issue 15645 - Tuple.slice() causes memory corruption #3975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9194e62
Fix issue 15645 - Tuple.slice() causes memory corruption
saurabhdas Feb 5, 2016
0d5f2c8
Make Tuple.slice() work with inout
saurabhdas Feb 6, 2016
0f8d900
Tuple.slice() - Use 'expand' instead of 'field'
saurabhdas Feb 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions std/typecons.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,14 +740,14 @@ template Tuple(Specs...)
* the original.
*/
@property
ref Tuple!(sliceSpecs!(from, to)) slice(size_t from, size_t to)() @trusted
inout(Tuple!(sliceSpecs!(from, to))) slice(size_t from, size_t to)() inout
if (from <= to && to <= Types.length)
{
return *cast(typeof(return)*) &(field[from]);
return Tuple!(sliceSpecs!(from, to))(expand[from .. to]);
}

///
unittest
@safe unittest
{
Tuple!(int, string, float, double) a;
a[1] = "abc";
Expand Down Expand Up @@ -983,6 +983,24 @@ private template ReverseTupleType(T)
alias ReverseTupleType = Tuple!(ReverseTupleSpecs!A);
}

/* Phobos issue #15645: Tuple.slice() causes memory corruption
https://issues.dlang.org/show_bug.cgi?id=15645 */
@safe unittest
{
Tuple!(int, int, long) b;
b[1] = 42;
b[2] = 101;
auto t = b.slice!(1, 3);
static assert(is(typeof(t) == Tuple!(int, long)));
assert(t[0] == 42 && t[1] == 102);

const auto c = tuple!("a", "b", "c")(42, true, "somestring");
auto u = c.slice!(1, 3);
static assert(is(typeof(u) == const(Tuple!(bool, "b", string, "c"))));
assert(c.b == true && c.c == "somestring");
}


/* Reverse the Specs of a Tuple. */
private template ReverseTupleSpecs(T...)
{
Expand Down