Skip to content

SList and Dlist should be forward ranges #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilzbach wants to merge 2 commits into from
Closed

SList and Dlist should be forward ranges #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b5cf4c
fix: {s,d}list should be an InputRange
wilzbach Mar 2, 2016
7f5a17f
merge upstream
wilzbach Mar 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions std/container/dlist.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ Complexity: $(BIGOH n).
{
return DList(this[]);
}
alias save = dup;

/**
Returns a range that iterates over all elements of the container, in
Expand Down Expand Up @@ -515,6 +516,7 @@ Complexity: $(BIGOH 1).

/// ditto
alias stableRemoveFront = removeFront;
alias popFront = removeFront;

/// ditto
void removeBack()
Expand All @@ -526,6 +528,7 @@ Complexity: $(BIGOH 1).

/// ditto
alias stableRemoveBack = removeBack;
alias popBack = removeBack;

/**
Removes $(D howMany) values at the front or back of the
Expand Down Expand Up @@ -945,3 +948,12 @@ private:
a.insertFront(iota(0, 5)); // can insert range with non-ref front
assert(a.front == 0 && a.back == 4);
}

unittest
{
import std.range;
// should be an input, forward and bidirectional range
assert(isInputRange!(DList!int));
assert(isForwardRange!(DList!int));
assert(isBidirectionalRange!(DList!int));
}
10 changes: 10 additions & 0 deletions std/container/slist.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ Complexity: $(BIGOH n).
{
return SList(this[]);
}
alias save = dup;

/**
Returns a range that iterates over all elements of the container, in
Expand Down Expand Up @@ -396,6 +397,7 @@ Complexity: $(BIGOH 1).

/// ditto
alias stableRemoveFront = removeFront;
alias popFront = removeFront;

/**
Removes $(D howMany) values at the front or back of the
Expand Down Expand Up @@ -819,3 +821,11 @@ unittest
s.reverse();
assert(s[].equal([3, 2, 1]));
}

unittest
{
import std.range;
// should be an input and forward range
assert(isInputRange!(SList!int));
assert(isForwardRange!(SList!int));
}