Skip to content

add documentation example for SList#4039

Merged
burner merged 1 commit intodlang:masterfrom
wilzbach:patch-1
Mar 4, 2016
Merged

add documentation example for SList#4039
burner merged 1 commit intodlang:masterfrom
wilzbach:patch-1

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Mar 2, 2016

As a follow-up to #4038 (my confusion that SList isn't an InputRange).

Here's an example that might help newcomers to gain a better understanding of SList.

The documentation on containers is still pretty sparse, but let's go step by step ;-)

@JackStouffer
Copy link
Contributor

Documentation examples should always be in unittest blocks. Otherwise the docs will stagnate if code changes.

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 3, 2016

@JackStouffer that makes totally sense ;-)
I updated all three PRs.

BTW I copied the "example template" with plain text examples from existing modules, so it make might sense to do a cleanup over old modules once ...

@ghost
Copy link

ghost commented Mar 4, 2016

You should take care not to waste too much time with std.containers improvment because it seems that the big boss will propose soon or later a replacement (see for example https://forum.dlang.org/thread/n07rh8$dmb$1@digitalmars.com or https://forum.dlang.org/thread/n3qq6e$2bis$1@digitalmars.com)

@burner
Copy link
Member

burner commented Mar 4, 2016

LGTM

@burner
Copy link
Member

burner commented Mar 4, 2016

Auto-merge toggled on

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 4, 2016

You should take care not to waste too much time with std.containers improvment because it seems that the big boss will propose soon or later a replacement

Thanks for the headsup, but for the time we have left on earth until god delivers us from our sins it will help other newcomers like myself ;-)

@ghost
Copy link

ghost commented Mar 4, 2016

I just mean that if one day the new containers come down to std.experimental you'll have a better playground. Like now with the allocators ;-)

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 4, 2016

I just mean that if one day the new containers come down to std.experimental you'll have a better playground. Like now with the allocators ;-)

Understood and really looking forward :)

@ghost
Copy link

ghost commented Mar 4, 2016

@greenify You may look at experimental ndslice since you like functional programming and have abilities with ranges, that's hot, new, and any improvment will have a direct impact on the quality.

std.container is not officially deprecated but almost.

burner added a commit that referenced this pull request Mar 4, 2016
add documentation example for SList
@burner burner merged commit 0beaf3f into dlang:master Mar 4, 2016
@wilzbach wilzbach deleted the patch-1 branch March 10, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants