convert docstring examples to unittests [setops]#4066
Merged
quickfur merged 1 commit intodlang:masterfrom Mar 9, 2016
Merged
Conversation
Member
|
LGTM |
Member
|
LGTM, merge ahoy! |
Member
|
Auto-merge toggled on |
quickfur
pushed a commit
that referenced
this pull request
Mar 9, 2016
convert docstring examples to unittests [setops]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #4044 as this might be a controversial edit.
This is part of my move to put more examples into unittests and here I put a modified version of the docstring after the example.
For the first example I preferred to show code instead of showing that how to generate the largestPartialIntersection with more than one item - I think this is nice, because it shows that the highest is the last element of the array and that one really has to duplicate the array to avoid it being emptied.