[Refactor] Generalize kickstart engines, in preparation for more to come#4217
Closed
DmitryOlshansky wants to merge 1 commit intodlang:masterfrom
Closed
[Refactor] Generalize kickstart engines, in preparation for more to come#4217DmitryOlshansky wants to merge 1 commit intodlang:masterfrom
DmitryOlshansky wants to merge 1 commit intodlang:masterfrom
Conversation
DmitryOlshansky
force-pushed
the
refactor-kickstart
branch
from
d5648e2 to
e502e2d
Compare
Member
Author
|
No idea about win32 failures. |
Member
|
Do we really need OOP here? Why not to use structural type system? |
Member
Author
|
The exact type of kickstart (many types in future) depends on the contents of a pattern which is run-time entity. |
Member
|
OK, we will be able to use refcounting or/and allocators in the future. |
Member
|
Auto-merge toggled on |
Member
Author
|
Auto-merge toggled off |
Member
Author
|
Please do not merge untill Win32 failures are resolved |
Member
|
sorry, my bad |
Member
|
needs rebase |
DmitryOlshansky
force-pushed
the
refactor-kickstart
branch
from
e502e2d to
57e8974
Compare
DmitryOlshansky
force-pushed
the
refactor-kickstart
branch
from
57e8974 to
2000b41
Compare
Member
Author
Looks like a compiler bug - tests pass without -O but fail with -O. |
Contributor
AFAIK the auto-tester won't merge the PR until it's green either way. ;) |
Member
Author
|
Superseded by #4286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes Kickstart engine an interface that an upcoming new engine will implement.