proper filtering of dscanner#4285
Conversation
|
Auto-merge toggled on |
.travis.yml
Outdated
| - (cd .. && rdmd ./checkwhitespace.d $(find phobos -name '*.d')) | ||
| - grep -E "(for|foreach|foreach_reverse|if|while)\(" $(find . -name '*.d'); test $? -eq 1 | ||
| - dscanResult=$(./dscanner --config .dscanner.ini --styleCheck std etc 2> /dev/null | grep -vE "(Empty declaration|Primary expression expected)") ; if [ -z "${dscanResult}" ] ; then echo "No warnings found" ; else echo $dscanResult && $(exit 1); fi | ||
| - ./dsc --config .dscanner.ini --styleCheck $(find std -type f -name '*.d' | grep -vE 'std/c/process.d|std/outbuffer.d|std/stream.d|std/traits.d|std/typecons.d|std/conv.d') |
There was a problem hiding this comment.
This filter should not be necessary now that v0.4.0-alpha3 is tagged. See dlang-community/dsymbol@ede71c4 for the fix of the root cause.
There was a problem hiding this comment.
Also it appears that there's a bug causing D-Scanner to not exit with a value of 1 when problems are found, so this won't fail correctly.
|
Auto-merge toggled off |
wilzbach
force-pushed
the
update_travis_dscanner
branch
from
9723d63 to
d833613
Compare
wilzbach
force-pushed
the
update_travis_dscanner
branch
from
d833613 to
c39d2ca
Compare
| - (cd Dscanner && git submodule update --init --recursive) | ||
| - (cd Dscanner && make githash debug) | ||
| # debug build is faster, but disable 'missing import' messages (missing core from druntime) | ||
| - (cd Dscanner && sed 's/dparse_verbose/StdLoggerDisableWarning/' -i makefile && make githash debug) |
There was a problem hiding this comment.
imports to core won't resolve (cloning this won't solve the problem, as it has imports to gcc/builtins and ldc/intrinsics)
There was a problem hiding this comment.
Please use dub fetch dscanner --version=0.4.0-alpha4 and dub run dscanner instead of cloning all repos. That would even allow to cache the .dub folder (though that is hardly faster).
There was a problem hiding this comment.
@MartinNowak currently building with dub doesn't work, but I do agree that this would be nicer!
wilzbach
force-pushed
the
update_travis_dscanner
branch
from
c39d2ca to
69a3d9e
Compare
|
@Hackerpilot thanks a lot for updating dscanner - bumped to alpha4 ;-) |
|
Auto-merge toggled on |
4 participants
It turns out that currently dscanner is failing, but we just silently filter these error messages.
Thus for (yet to be known reasons) dscanner throws exceptions for a couple of modules in
std(and everything inetc). I will try to dig deeper into the assertion error, but for now this should actually test most of phobos with dscanner ;-)the replacement
sed 's/dparse_verbose/StdLoggerDisableWarning/'is to use the fast debug build without any debug logging ;-)Ping @CyberShadow @Hackerpilot