add top-level example for binary heap#4331
Conversation
8dc8640 to
5ff65fa
Compare
|
I need to fix the authorship on these submodules :) I only wrote the RedBlackTree, and Andrei and others wrote everything else! |
|
@wilzbach can you split these kind of PR's either it is a doc PR or it is an code enhancement. IMO this PR should be closed and split into multiple new PR's, each with a singular focus. |
5ff65fa to
f8b363b
Compare
Sorry. Ok, makes sense,
I rebased this PR to be just about the added unittest example to the documentation. Hope this reduces the noise a bit ;-) |
std/container/binaryheap.d
Outdated
| /// | ||
| unittest | ||
| { | ||
| import std.algorithm : equal; |
There was a problem hiding this comment.
isn't equal in std.algorithm.comparison ? I mean if you use selected imports, use them on deepest nested module.
|
Other than my remark about the imports LGTM |
f8b363b to
a3f229f
Compare
4bf1489 to
5f7a4ca
Compare
Rebased, but now it fails, because it depends on the bug fix #4359 :/ |
|
Auto-merge toggled on |
Ping @schveiguy