Skip to content

Fix bad host.#4410

Merged
CyberShadow merged 2 commits intodlang:masterfrom
veelo:patch-3
Jun 7, 2016
Merged

Fix bad host.#4410
CyberShadow merged 2 commits intodlang:masterfrom
veelo:patch-3

Conversation

@veelo
Copy link
Contributor

@veelo veelo commented Jun 5, 2016

LINK2 is OK for external links, right?

LINK2 is OK for external links, right?
@aG0aep6G
Copy link
Contributor

aG0aep6G commented Jun 5, 2016

LINK2 is OK for external links, right?

Yep.

std/zip.d Outdated

/**
* Read/write data in the $(LINK2 http://www.info-_zip.org, zip archive) format.
* Read/write data in the $(LINK2 http://www.info-zip.org, zip archive) format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to put an underscore before the second "zip", here. Otherwise it generates an <a> element for an anchor, and that messes with the <a> from the LINK2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request to tackle this in the macro definitions: dlang/dlang.org#1338

Should still put the underscore before the second "zip", though.

@veelo
Copy link
Contributor Author

veelo commented Jun 5, 2016

Like this?

@CyberShadow
Copy link
Member

Auto-merge toggled on

@CyberShadow CyberShadow merged commit e74b2a4 into dlang:master Jun 7, 2016
@veelo
Copy link
Contributor Author

veelo commented Jun 7, 2016

WEB is even better

Why is it better? Ref #4411.

@veelo veelo deleted the patch-3 branch June 7, 2016 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants