Fix issue 4509 - XML parser in std.xml throws TagException if the attr value is put in apostrophes.#4567
Merged
quickfur merged 3 commits intodlang:masterfrom Jul 6, 2016
Merged
Conversation
Fixes issue 4509 - XML parser in std.xml throws TagException if the attr value is put in apostrophes.
Also remove extra trailing newlines at the end of the file.
Contributor
|
Contributor
|
✅ |
Contributor
Author
|
Added a commit to actually do the parsing so that the asserts are actually run :S |
Contributor
Author
|
I don't get the Travis CI failure. It says:
std.internal.phobosinit has been added in #4493, but Travis CI has been green there. And it's green on other PRs. |
Member
|
Not only that, but the warning is inaccurate. That is the perfect place to do a wholesale import of another module. Why was that warning added as a requirement? |
Member
|
Probably need to rebase on HEAD to get the Other than that, LGTM. |
Contributor
Author
|
Triggered a re-run of Travis CI. Is green now. |
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #4064 which @CoderAbhishek wasn't able to finish. I've added the requested asserts in a separate commit. CC @quickfur.
If this gets merged, #4064 can be closed.