Added Asserts and Messages to Asserts in std.algorithm.iteration#4602
Merged
quickfur merged 1 commit intodlang:masterfrom Jul 15, 2016
Merged
Added Asserts and Messages to Asserts in std.algorithm.iteration#4602quickfur merged 1 commit intodlang:masterfrom
quickfur merged 1 commit intodlang:masterfrom
Conversation
std/algorithm/iteration.d
Outdated
| assert( | ||
| low <= high, | ||
| "Attempting to slice a cache with a larger first argument than the second" | ||
| ); |
Member
There was a problem hiding this comment.
Four lines is really overdoing it. Also the message is prolix.
assert(low <= high, "Bounds error in cache slicing.");Also you need to decide whether you always end with the period or not (you did so far).
JackStouffer
force-pushed
the
algorithm_assert_messages
branch
from
b5620b0 to
c9222e1
Compare
Contributor
Author
|
@andralex Fixed |
Member
|
LGTM. Thanks! |
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #4568 and #4573