Fix issue 16291 -- phobosinit fails to register encodings on individual tests

[schveiguy]

I'm going to attempt moving these ctors back, and make sure the dependency graph is properly set up. Testing locally, I no longer have any cycles. The cycle detection code is now fixed, so if cycles return, I'll have to figure out a different way to solve this.

Please do NOT pull until the auto-tester has checked for cycles.

See related PRs for history: dlang/druntime#1602 and #4493

[dlang-bot]

Fix	Bugzilla	Description
✓	16291	phobosinit fails to register encodings on individual tests

[dlang-bot]

@schveiguy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @tchaloupka, @andralex and @lionello to be potential reviewers. @tchaloupka: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

[dlang-bot]

@schveiguy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @JackStouffer, @kyllingstad and @andralex to be potential reviewers. @JackStouffer: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

[codecov-io]

Current coverage is 88.78% (diff: 100%)

Merging #4743 into master will decrease coverage by <.01%

@@             master      #4743   diff @@
==========================================
  Files           121        120     -1   
  Lines         74159      74151     -8   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          65845      65837     -8   
  Misses         8314       8314          
  Partials          0          0          

Powered by Codecov. Last update 0538d0c...4557020

[JackStouffer]

lol apparently this was supposed to be assigned to me, but since I'm not part of this repo it did nothing.

[JackStouffer]

@schveiguy Why not just use git to revert the commit that made this change?

[schveiguy]

apparently this was supposed to be assigned to me

The bot has issues :) dlang-bots/mention-bot#7

Why not just use git to revert the commit that made this change

The commit was more than just this, including renaming processinit to phobosinit (which I think is more appropriate if we have to add more of this shit). I don't want to revert all that.

[schveiguy]

OK, the windows issue is the one that didn't fail on OSX. I need to figure out that bug (there is definitely a cycle, as I recall, but it's just not detected on some OSes), and also rearrange how this is done so the phobosinit gets pulled in. Stay tuned.