Fix Issue 16571 - Unittests should not list /tmp/ recursively#4838
Merged
AndrejMitrovic merged 1 commit intodlang:masterfrom Oct 4, 2016
joakim-noah:temp
Merged
Fix Issue 16571 - Unittests should not list /tmp/ recursively#4838AndrejMitrovic merged 1 commit intodlang:masterfrom joakim-noah:temp
AndrejMitrovic merged 1 commit intodlang:masterfrom
joakim-noah:temp
Conversation
Contributor
|
Contributor
|
Auto-merge toggled on |
This was referenced Dec 24, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the call to
dirEntriesaltogether, as it's not needed to make sure the function compiles. As the original bug writeup for 15319 shows, this test is only to make sure this function always compiles, but the original author simply copied the testcase withdirEntriesfrom bugzilla. Since that adds nothing to a simple compile check, I just removed it.Update: also marked this test as
@safenow.