Merged
Conversation
Contributor
|
Member
Author
|
@wilzbach Do I need to do something about the codecov "failure"? |
Contributor
Not at all - it's just warning you that by reverting you remove some tests and thus the overall coverage. That's why it's only a warning and not required ;-) edit: the added tests isn't executed, thus the "new unhit" lines. |
Member
Author
|
Thanks. Though I think the decreased coverage is due to the compilation "test", which generates uncovered (and uncoverable) lines. |
MartinNowak
approved these changes
Oct 24, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4273
https://issues.dlang.org/show_bug.cgi?id=16514