Skip to content

{please} Implicit cast to const slices#4869

Merged
MartinNowak merged 1 commit intodlang:masterfrom
9il:stable
Oct 19, 2016
Merged

{please} Implicit cast to const slices#4869
MartinNowak merged 1 commit intodlang:masterfrom
9il:stable

Conversation

@9il
Copy link
Member

@9il 9il commented Oct 16, 2016 •
edited
Loading

This is required

  1. To reduce template bloat in generic GLAS.
  2. For precompiled GLAS API.

All Mir tests pass

@9il 9il added the ndslice label Oct 16, 2016
@9il 9il added this to the 2.072.0 milestone Oct 16, 2016
@9il 9il changed the title Implicit cast to const slices in case of underlaying range is a pointer. Implicit cast to const slices Oct 16, 2016
@9il
Copy link
Member Author

9il commented Oct 17, 2016

ping @MartinNowak

@9il 9il changed the title Implicit cast to const slices {please} Implicit cast to const slices Oct 17, 2016
@MartinNowak
Copy link
Member

MartinNowak commented Oct 19, 2016

Auto-merge toggled on

@MartinNowak MartinNowak merged commit 336f5c4 into dlang:master Oct 19, 2016
@9il
Copy link
Member Author

9il commented Oct 19, 2016

Thanks!

@9il 9il deleted the stable branch October 19, 2016 09:37
@MartinNowak
Copy link
Member

MartinNowak commented Oct 19, 2016 •
edited
Loading

This is now in master not in stable @9il. Is it really necessary for 2.072?
Our beta is almost over, we should merge new features/changes.

@9il
Copy link
Member Author

9il commented Oct 19, 2016

Yes, this is required for Mir to remove ndslice copy.

@9il 9il restored the stable branch October 20, 2016 21:25
@9il 9il mentioned this pull request Oct 20, 2016
Merged
@9il 9il deleted the stable branch October 24, 2016 07:42
@9il 9il restored the stable branch November 11, 2016 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinNowak MartinNowak MartinNowak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.072.0

Development

Successfully merging this pull request may close these issues.

2 participants

@9il @MartinNowak