Resurrect ApplyLeft and ApplyRight's documentation#4875
Merged
MartinNowak merged 1 commit intodlang:stablefrom Oct 24, 2016
Merged
Resurrect ApplyLeft and ApplyRight's documentation#4875MartinNowak merged 1 commit intodlang:stablefrom
MartinNowak merged 1 commit intodlang:stablefrom
Conversation
Also put the signature of `isImplicitlyConvertible` in a comment to make the example more clear.
Member
Author
|
Ping @MartinNowak I'm targeting the stable branch because this a trivial change (just moving stuff around) and because I don't want to wait several months for the non-prerelease documentation to be updated. |
Member
Author
Member
Our release cycle is supposed to be 2 month. The last one was an exception due to the big import/lookup change. So impatience is not argument for addressing stable, but bugfixes (like this PR) should always go into stable. |
MartinNowak
approved these changes
Oct 24, 2016
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that PR #4374 introduced a private symbol (
SmartAlias) betweenApplyLeftandApplyRight's and they're ddoc-ed unittests. Since ddoc-ed unittests bind to first symbol above them and that symbol was private, they were omitted from documentation.Also put the signature of
isImplicitlyConvertiblein a comment to make the example more clear.