Skip to content

Resurrect ApplyLeft and ApplyRight's documentation#4875

Merged
MartinNowak merged 1 commit intodlang:stablefrom
PetarKirov:patch-7
Oct 24, 2016
Merged

Resurrect ApplyLeft and ApplyRight's documentation#4875
MartinNowak merged 1 commit intodlang:stablefrom
PetarKirov:patch-7

Conversation

@PetarKirov
Copy link
Member

@PetarKirov PetarKirov commented Oct 23, 2016

The issue was that PR #4374 introduced a private symbol (SmartAlias) between ApplyLeft and ApplyRight's and they're ddoc-ed unittests. Since ddoc-ed unittests bind to first symbol above them and that symbol was private, they were omitted from documentation.

Also put the signature of isImplicitlyConvertible in a comment to make the example more clear.

Also put the signature of `isImplicitlyConvertible` in a comment to make the example more clear.
@PetarKirov
Copy link
Member Author

Ping @MartinNowak I'm targeting the stable branch because this a trivial change (just moving stuff around) and because I don't want to wait several months for the non-prerelease documentation to be updated.

@PetarKirov
Copy link
Member Author

For comparison: before and after.

@MartinNowak
Copy link
Member

Ping @MartinNowak I'm targeting the stable branch because this a trivial change (just moving stuff around) and because I don't want to wait several months for the non-prerelease documentation to be updated.

Our release cycle is supposed to be 2 month. The last one was an exception due to the big import/lookup change. So impatience is not argument for addressing stable, but bugfixes (like this PR) should always go into stable.

@MartinNowak MartinNowak merged commit d8ca14c into dlang:stable Oct 24, 2016
@PetarKirov
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants