Skip to content

[trivial] std.conv: Don't allow to!T() in constraint #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schveiguy merged 4 commits into from
Nov 23, 2016
Merged

[trivial] std.conv: Don't allow to!T() in constraint #4898

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
006ee44
Fix Issue 16478 - Don't allow to!T() in constraint
ntrel Nov 12, 2016
b967d94
Remove isRawStaticArray - same as isStaticArray
ntrel Nov 12, 2016
43f3780
Defer doc changes to another PR
ntrel Nov 14, 2016
b612dcd
Fix constraint
schveiguy Nov 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions std/conv.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,6 @@ private
enum isNullToStr = isImplicitlyConvertible!(S, T) &&
(is(Unqual!S == typeof(null))) && isExactSomeString!T;
}

template isRawStaticArray(T, A...)
{
enum isRawStaticArray =
A.length == 0 &&
isStaticArray!T &&
!is(T == class) &&
!is(T == interface) &&
!is(T == struct) &&
!is(T == union);
}
}

/**
Expand Down Expand Up @@ -178,14 +167,14 @@ $(I UnsignedInteger):
template to(T)
{
T to(A...)(A args)
if (!isRawStaticArray!A)
if (A.length != 1 || !isStaticArray!(A[0]))
{
return toImpl!T(args);
}

// Fix issue 6175
T to(S)(ref S arg)
if (isRawStaticArray!S)
if (isStaticArray!S)
{
return toImpl!T(arg);
}
Expand Down Expand Up @@ -536,7 +525,7 @@ private T toImpl(T, S)(S value)
Converting static arrays forwards to their dynamic counterparts.
*/
private T toImpl(T, S)(ref S s)
if (isRawStaticArray!S)
if (isStaticArray!S)
{
return toImpl!(T, typeof(s[0])[])(s);
}
Expand Down